Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2711363003: Use DidFinishNavigation callback in LanguageDetectionController. (Closed)
Patch Set: Removed unused method Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/web_state/web_state_observer_bridge.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 6d0fb2cfa2b052059efebef06219a0dee45a6672..333a0d68c8e9d5f49dce8b82604e55afd74d28f6 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2862,8 +2862,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
item->SetIsCreatedFromHashChange(true);
}
- // Notify the observers.
- _webStateImpl->OnUrlHashChanged();
return YES;
}
@@ -2962,8 +2960,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
return;
base::scoped_nsobject<CRWWebController> strongSelf([weakSelf retain]);
[strongSelf optOutScrollsToTopForSubviews];
- // Notify the observers.
- strongSelf.get()->_webStateImpl->OnHistoryStateChanged();
[strongSelf didFinishNavigation];
}];
return YES;
« no previous file with comments | « ios/web/public/web_state/web_state_observer_bridge.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698