Use DidFinishNavigation callback in LanguageDetectionController.

ios/web/web_state/web_state_impl_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/web_state_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 109 matching lines @@
 // expected.
 class TestWebStateObserver : public WebStateObserver {
  public:
   TestWebStateObserver(WebState* web_state)
       : WebStateObserver(web_state),
         provisional_navigation_started_called_(false),
         navigation_items_pruned_called_(false),
         navigation_item_changed_called_(false),
         navigation_item_committed_called_(false),
         page_loaded_called_with_success_(false),
-        url_hash_changed_called_(false),
         history_state_changed_called_(false),
         did_finish_navigation_called_(false),
         web_state_destroyed_called_(false) {}
 
   // Methods returning true if the corresponding WebStateObserver method has
   // been called.
   bool provisional_navigation_started_called() const {
     return provisional_navigation_started_called_;
   };
   bool navigation_items_pruned_called() const {
     return navigation_items_pruned_called_;
   }
   bool navigation_item_changed_called() const {
     return navigation_item_changed_called_;
   }
   bool navigation_item_committed_called() const {
     return navigation_item_committed_called_;
   }
   bool page_loaded_called_with_success() const {
     return page_loaded_called_with_success_;
   }
-  bool url_hash_changed_called() const { return url_hash_changed_called_; }
   bool history_state_changed_called() const {
     return history_state_changed_called_;
   }
   bool did_finish_navigation_called() const {
     return did_finish_navigation_called_;
   }
   bool web_state_destroyed_called() const {
     return web_state_destroyed_called_;
   }
 
@@ skipping 12 matching lines @@
       const LoadCommittedDetails& load_details) override {
     navigation_item_committed_called_ = true;
   }
   void DidFinishNavigation(NavigationContext* navigation_context) override {
     did_finish_navigation_called_ = true;
   }
   void PageLoaded(PageLoadCompletionStatus load_completion_status) override {
     page_loaded_called_with_success_ =
         load_completion_status == PageLoadCompletionStatus::SUCCESS;
   }
-  void UrlHashChanged() override { url_hash_changed_called_ = true; }
-  void HistoryStateChanged() override { history_state_changed_called_ = true; }
   void WebStateDestroyed() override {
     EXPECT_TRUE(web_state()->IsBeingDestroyed());
     web_state_destroyed_called_ = true;
     Observe(nullptr);
   }
 
   bool provisional_navigation_started_called_;
   bool navigation_items_pruned_called_;
   bool navigation_item_changed_called_;
   bool navigation_item_committed_called_;
   bool page_loaded_called_with_success_;
-  bool url_hash_changed_called_;
   bool history_state_changed_called_;
   bool did_finish_navigation_called_;
   bool web_state_destroyed_called_;
 };
 
 // Test decider to check that the WebStatePolicyDecider methods are called as
 // expected.
 class MockWebStatePolicyDecider : public WebStatePolicyDecider {
  public:
   explicit MockWebStatePolicyDecider(WebState* web_state)
@@ skipping 176 matching lines @@
   web_state_->OnNavigationItemCommitted(details);
   EXPECT_TRUE(observer->navigation_item_committed_called());
 
   // Test that OnPageLoaded() is called with success when there is no error.
   EXPECT_FALSE(observer->page_loaded_called_with_success());
   web_state_->OnPageLoaded(GURL("http://test"), false);
   EXPECT_FALSE(observer->page_loaded_called_with_success());
   web_state_->OnPageLoaded(GURL("http://test"), true);
   EXPECT_TRUE(observer->page_loaded_called_with_success());
 
-  // Test that UrlHashChanged() is called.
-  EXPECT_FALSE(observer->url_hash_changed_called());
-  web_state_->OnUrlHashChanged();
-  EXPECT_TRUE(observer->url_hash_changed_called());
-
-  // Test that HistoryStateChanged() is called.
-  EXPECT_FALSE(observer->history_state_changed_called());
-  web_state_->OnHistoryStateChanged();
-  EXPECT_TRUE(observer->history_state_changed_called());
-
   // Test that DidFinishNavigation() is called for same page navigations.
   EXPECT_FALSE(observer->did_finish_navigation_called());
   web_state_->OnSamePageNavigation(GURL("http://test"));
   EXPECT_TRUE(observer->did_finish_navigation_called());
 
   // Reset the observer and test that DidFinishNavigation() is called
   // for error navigations.
   observer = base::MakeUnique<TestWebStateObserver>(web_state_.get());
   EXPECT_FALSE(observer->did_finish_navigation_called());
   web_state_->OnErrorPageNavigation(GURL("http://test"));
@@ skipping 274 matching lines @@
       "</script>");
 
   base::test::ios::WaitUntilCondition(^{
     return message_received;
   });
   web_state_->RemoveScriptCommandCallback("test");
 }
 
 }  // namespace
 }  // namespace web