Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2711353003: Fixed tests not having MallocHooks initialized for tests in release mode. (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed tests not having MallocHooks initialized for tests in release mode. Revert "Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection."" This reverts commit 1a5b555aa9fa359f74f6613bdf52b0f6117e31b6. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/68a102cab2ee8d25aaa1afa1a8a132e34beb46bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+728 lines, -235 lines) Patch
M runtime/vm/benchmark_test.h View 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/malloc_hooks.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 12 chunks +211 lines, -88 lines 0 comments Download
M runtime/vm/malloc_hooks_test.cc View 3 chunks +123 lines, -4 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M runtime/vm/object_test.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_thread.h View 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/profiler.h View 12 chunks +29 lines, -15 lines 0 comments Download
M runtime/vm/profiler.cc View 23 chunks +128 lines, -51 lines 0 comments Download
M runtime/vm/profiler_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/profiler_service.cc View 6 chunks +44 lines, -10 lines 0 comments Download
M runtime/vm/profiler_test.cc View 52 chunks +57 lines, -56 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/source_report.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/disassemble_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
This should fix the failing tests on release builds. All the relevant changes are in ...
3 years, 10 months ago (2017-02-24 20:47:10 UTC) #2
zra
lgtm
3 years, 10 months ago (2017-02-24 20:49:30 UTC) #3
bkonyi
3 years, 10 months ago (2017-02-24 21:56:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
68a102cab2ee8d25aaa1afa1a8a132e34beb46bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698