Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2711313005: [NOT FOR REVIEW] Tracing performance assessment for task profiler. (Closed)

Created:
3 years, 9 months ago by kraynov
Modified:
3 years, 9 months ago
CC:
picksi, Sigurður Ásgeirsson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NOT FOR REVIEW] Tracing performance assessment for task profiler. tot == top of trunk with default args, old == top of trunk with enable_memory_task_profiler=false, see tot.args.gn and old.args.gn. Test device: Nexus 5. See perf_cmp.py for comparison metric. BUG=695522

Patch Set 1 #

Patch Set 2 : TracedValue test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9384 lines, -0 lines) Patch
A components/tracing/experiment/data/old_1.log View 1 1 chunk +95 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_10.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_11.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_12.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_13.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_14.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_15.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_16.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_17.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_18.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_19.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_2.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_20.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_21.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_22.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_23.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_24.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_25.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_26.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_27.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_28.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_29.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_3.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_30.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_31.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_32.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_33.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_34.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_35.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_36.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_37.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_38.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_39.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_4.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_40.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_41.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_42.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_43.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_44.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_45.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_46.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_47.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_48.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_49.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_5.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_50.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_6.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_7.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_8.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/old_9.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_1.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_10.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_11.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_12.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_13.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_14.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_15.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_16.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_17.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_18.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_19.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_2.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_20.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_21.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_22.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_23.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_24.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_25.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_26.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_27.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_28.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_29.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_3.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_30.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_31.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_32.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_33.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_34.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_35.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_36.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_37.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_38.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_39.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_4.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_40.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_41.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_42.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_43.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_44.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_45.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_46.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_47.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_48.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_49.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_5.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_50.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_6.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_7.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_8.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/data/tot_9.log View 1 1 chunk +93 lines, -0 lines 0 comments Download
A components/tracing/experiment/old.args.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
A components/tracing/experiment/perf_cmp.py View 1 1 chunk +65 lines, -0 lines 0 comments Download
A components/tracing/experiment/tot.args.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/tracing/test/trace_event_perftest.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
kraynov
Submit_10000_TRACE_EVENT0_multithreaded: events_over_multiple_threads [98, 100, 100, 102, 102, 103, 103, 104, 106, 110, 110, 111, 112, ...
3 years, 9 months ago (2017-02-24 13:57:15 UTC) #2
kraynov
3 years, 9 months ago (2017-02-27 08:36:51 UTC) #3
As I can see in previous figures, regression by median was observed (see
previous message) in tests involving TracedValue. And other graphs (without
TracedValue) look like a noise deviation. So my sespect is that creation of
TracedValue became somehow slower.

I've added test (see patch set #2) which creates 10M TracedValue and got the
following results on Nexus 5:
tot: 55,116ms 55,635ms and 58,842ms
old: 52,906ms 50,187ms and 51,113ms

Looks like regression is here.

Powered by Google App Engine
This is Rietveld 408576698