Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2711273003: [Fuchsia] Use magenta/process.h for mx_job_default, mx_vmar_root_self (Closed)

Created:
3 years, 10 months ago by dbort
Modified:
3 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Use magenta/process.h for mx_job_default, mx_vmar_root_self Those symbols will soon be removed from magenta/syscalls.h. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c6b5c19347db1d69735253c162917fc8d703637b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/bin/process_fuchsia.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dbort
Moved over from https://chromium-review.googlesource.com/c/446741/ Please let me know if I need to do anything for ...
3 years, 10 months ago (2017-02-24 05:02:24 UTC) #2
dbort
Also, magenta/process.h just appeared last week (https://fuchsia.googlesource.com/magenta/+/682950dadc4f239ec51a52610d3437df0a64e24c); I don't know if this project needs to ...
3 years, 10 months ago (2017-02-24 05:05:39 UTC) #3
zra
lgtm lgtm I'll land this for you.
3 years, 10 months ago (2017-02-24 15:59:41 UTC) #4
zra
Committed patchset #1 (id:1) manually as c6b5c19347db1d69735253c162917fc8d703637b (presubmit successful).
3 years, 10 months ago (2017-02-24 16:00:52 UTC) #6
dbort
3 years, 10 months ago (2017-02-24 19:54:59 UTC) #7
Message was sent while issue was closed.
On 2017/02/24 15:59:41, zra wrote:
> I'll land this for you.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698