Issue 2711253004: When metadata is not requested, elide unneeded signatures

Issue 2711253004: When metadata is not requested, elide unneeded signatures (Closed)

Created:
3 years, 10 months ago by Leaf

Modified:
3 years, 10 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

When metadata is not requested, elide signature information that is not needed for dynamic checks (static fields/getters/setters and constructors). BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/ef120f105f288fff4fab1a83843557d63c9627a9

Created: 3 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+652 lines, -25550 lines)			Patch
M	pkg/dev_compiler/lib/js/amd/dart_sdk.js	View	1	1488 chunks	+151 lines, -6373 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/common/dart_sdk.js	View	1	1488 chunks	+151 lines, -6373 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/es6/dart_sdk.js	View	1	1488 chunks	+151 lines, -6373 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/legacy/dart_sdk.js	View	1	1488 chunks	+151 lines, -6373 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1	5 chunks	+37 lines, -26 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/closure.js	View	1	3 chunks	+0 lines, -14 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/destructuring.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js.map	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/varargs.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 6 (3 generated)

Leaf

3 years, 10 months ago (2017-02-24 20:59:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:10001) manually as
ef120f105f288fff4fab1a83843557d63c9627a9 (presubmit successful).