Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2711233002: Remove addFile() invocations in analyzer_cli. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove addFile() invocations in analyzer_cli. Now that we always get errors when we ask for the result, we don't need adding these files. This makes analysis of shared tests about 15-20% faster. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/91d62cb226091342adec1704fddfaa29624859ab

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 3 chunks +1 line, -8 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-23 22:09:39 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2711233002/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2711233002/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode225 pkg/analyzer_cli/lib/src/driver.dart:225: if (analysisDriver != null) {} else { Reverse ...
3 years, 10 months ago (2017-02-23 22:18:09 UTC) #2
scheglov
3 years, 10 months ago (2017-02-23 22:41:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91d62cb226091342adec1704fddfaa29624859ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698