Make print interceptable.

runtime/bin/dartutils.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
@@ skipping 642 matching lines @@
     return Dart_LoadLibrary(url, source);
   } else if (tag == Dart_kSourceTag) {
     return Dart_LoadSource(library, url, source);
   }
   return Dart_Error("wrong tag");
 }
 
 
 Dart_Handle DartUtils::PrepareForScriptLoading(const char* package_root,
                                                Dart_Handle builtin_lib) {
-  Dart_Handle corelib = Dart_LookupLibrary(NewString("dart:core"));
-  DART_CHECK_VALID(corelib);
-
-  // Setup the corelib 'print' function.
+  // Setup the internal library's 'internalPrint' function.
+  Dart_Handle internal_lib =
+      Dart_LookupLibrary(NewString("dart:_collection-dev"));

[Ivan Posva, 2013/10/16 07:19:51]

In my opinion this has nothing to do with any collections and we keep throwing
more stuff in there that doesn't belong.

[floitsch, 2013/10/16 07:38:56]

Yes. we want to rename it, but since it's not user-visible it never reached the
top of our TODO lists.
Filed dartbug.com/14140.

+  DART_CHECK_VALID(internal_lib);
   Dart_Handle print = Dart_Invoke(
       builtin_lib, NewString("_getPrintClosure"), 0, NULL);
-  Dart_Handle result = Dart_SetField(corelib,
+  Dart_Handle result = Dart_SetField(internal_lib,
                                      NewString("_printClosure"),
                                      print);
   DART_CHECK_VALID(result);
 
   // Setup the 'timer' factory.
   Dart_Handle url = NewString(kAsyncLibURL);
   DART_CHECK_VALID(url);
   Dart_Handle async_lib = Dart_LookupLibrary(url);
   DART_CHECK_VALID(async_lib);
   Dart_Handle io_lib = Builtin::LoadAndCheckLibrary(Builtin::kIOLibrary);
   Dart_Handle timer_closure =
       Dart_Invoke(io_lib, NewString("_getTimerFactoryClosure"), 0, NULL);
   Dart_Handle args[1];
   args[0] = timer_closure;
   DART_CHECK_VALID(Dart_Invoke(
       async_lib, NewString("_setTimerFactoryClosure"), 1, args));
 
   // Setup the corelib 'Uri.base' getter.
+  Dart_Handle corelib = Dart_LookupLibrary(NewString("dart:core"));
+  DART_CHECK_VALID(corelib);
   Dart_Handle uri_base = Dart_Invoke(
       builtin_lib, NewString("_getUriBaseClosure"), 0, NULL);
   DART_CHECK_VALID(uri_base);
   result = Dart_SetField(corelib,
                          NewString("_uriBaseClosure"),
                          uri_base);
   DART_CHECK_VALID(result);
 
   if (IsWindowsHost()) {
     // Set running on Windows flag.
@@ skipping 326 matching lines @@
       new CObjectString(CObject::NewString(os_error->message()));
   CObjectArray* result = new CObjectArray(CObject::NewArray(3));
   result->SetAt(0, new CObjectInt32(CObject::NewInt32(kOSError)));
   result->SetAt(1, new CObjectInt32(CObject::NewInt32(os_error->code())));
   result->SetAt(2, error_message);
   return result;
 }
 
 }  // namespace bin
 }  // namespace dart