sdk/lib/core/print.dart - Issue 27112002: Make print interceptable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/core/print.dart

Issue 27112002: Make print interceptable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 part of dart.core;	5 part of dart.core;

6	6

7 external void print(Object object);	7 void print(Object object) {

	8 String line = object.toString();

	9 if (printToZone != null) {

	10 printToZone(line);
	Lasse Reichstein Nielsen 2013/10/15 14:12:02 Switch the two cases? I find it slightly easier t Switch the two cases? I find it slightly easier to read a positive test. Do we have any idea whether the majority of programs will use one or the other? floitsch 2013/10/15 15:56:20 done. Show quoted text On 2013/10/15 14:12:02, Lasse Reichstein Nielsen wrote: > Switch the two cases? done. Show quoted text > I find it slightly easier to read a positive test. > > Do we have any idea whether the majority of programs will use one or the other? Once a zone is instantiated it will be printToZone. So it depends on the usage of zones.
	11 } else {

	12 printToConsole(line);

	13 }

	14 }

OLD	NEW