sdk/lib/_collection_dev/print.dart - Issue 27112002: Make print interceptable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/_collection_dev/print.dart

Issue 27112002: Make print interceptable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make it easier for dart2js. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « sdk/lib/_collection_dev/collection_dev_sources.gypi ('k') | sdk/lib/_internal/lib/collection_dev_patch.dart » ('j') | sdk/lib/_internal/lib/collection_dev_patch.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 part of dart._collection.dev;

	6

	7 /**
	kasperl 2013/10/15 13:14:46 Isn't this a seriously weird place for this functi Isn't this a seriously weird place for this functionality to live? What does it have to do with collections? floitsch 2013/10/15 13:46:49 _collection_dev is currently our internal library. Show quoted text On 2013/10/15 13:14:46, kasperl wrote: > Isn't this a seriously weird place for this functionality to live? What does it > have to do with collections? _collection_dev is currently our internal library. We need to rename it to _internal_lib or similar, but since it's not user-facing it never went high enough on our TODO lists.
	8 * This function is set by the first allocation of a Zone.

	9 *

	10 * Once the function is set the core `print` function calls this closure instead

	11 * of [consolePrint].

	12 *

	13 * This makes it more efficient for dart2js to tree-shake tiny hello-world

	14 * programs.

	15 */

	16 Function zonePrint = null;
	kasperl 2013/10/15 13:14:46 I'd consider using print as a prefix (so something I'd consider using print as a prefix (so something like printToZone, printToConsole). floitsch 2013/10/15 13:46:49 Done. Show quoted text On 2013/10/15 13:14:46, kasperl wrote: > I'd consider using print as a prefix (so something like printToZone, > printToConsole). Done.
	17

	18 external void consolePrint(String line);

OLD	NEW