Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html

Issue 2711183003: Import wpt@a7e9c2abcf65b78fcf1c246fec6681c74e1bc352 (Closed)
Patch Set: Update test expectations and baselines. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html
index 09278d2028b8d65963fb6399e8b364f6a643e2c4..d1bb4335207cb20bd9463b24f2be75dcc22b5dda 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/styling/LinkStyle.html
@@ -29,14 +29,27 @@
<div id="test" style="display:none">STYLING TEST</div>
<script>
- test(function() {
- var style = null,
- i;
- for (i = 1; i < 5; i++) {
- style = document.getElementById("style" + i);
- assert_equals(style.sheet, null, "The sheet attribute of style" + i + " should be null.");
- assert_false(style.disabled, "The disabled attribute of style" + i + " should be false.");
- }
+ /**
+ * Browsers may incorrectly issue requests for these resources and defer
+ * definition of the `sheet` attribute until after loading is complete.
+ * In such cases, synchronous assertions regarding the absence of
+ * attributes will spuriously pass.
+ *
+ * In order to account for this incorrect behavior (exhibited at the time
+ * of this writing most notably by the Chromium browser), defer the
+ * assertions until the "load" event has been triggered.
+ */
+ async_test(function(t) {
+ window.addEventListener("load", t.step_func(function() {
+ var style = null,
+ i;
+ for (i = 1; i < 5; i++) {
+ style = document.getElementById("style" + i);
+ assert_equals(style.sheet, null, "The sheet attribute of style" + i + " should be null.");
+ assert_false(style.disabled, "The disabled attribute of style" + i + " should be false.");
+ }
+ t.done();
+ }));
}, "The LinkStyle interface's sheet attribute must return null; the disabled attribute must be false");
test(function() {
@@ -46,14 +59,17 @@
assert_equals(link.sheet, null, "The sheet attribute of the link element not in a document should be null.");
}, "The LinkStyle interface's sheet attribute must return null if the corresponding element is not in a Document");
- test(function() {
- var style = null,
- i;
- for (i = 5; i < 8; i++) {
- style = document.getElementById("style" + i);
- assert_true(style.sheet instanceof StyleSheet, "The sheet attribute of style" + i + " should be a StyleSheet object.");
- assert_equals(style.disabled, style.sheet.disabled, "The disabled attribute of style" + i + " should equal to the same attribute of StyleSheet.");
- }
+ async_test(function(t) {
+ window.addEventListener("load", t.step_func(function() {
+ var style = null,
+ i;
+ for (i = 5; i < 8; i++) {
+ style = document.getElementById("style" + i);
+ assert_true(style.sheet instanceof StyleSheet, "The sheet attribute of style" + i + " should be a StyleSheet object.");
+ assert_equals(style.disabled, style.sheet.disabled, "The disabled attribute of style" + i + " should equal to the same attribute of StyleSheet.");
+ }
+ t.done();
+ }));
}, "The LinkStyle interface's sheet attribute must return StyleSheet object; the disabled attribute must be same as the StyleSheet's disabled attribute");
test(function() {

Powered by Google App Engine
This is Rietveld 408576698