Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2711183002: Store toString value in enum. (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store toString value in enum. This avoids the use of an constant map per enum. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/a22350458bbfd7548c7e4e09175bb7896f89b3ea

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -39 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +8 lines, -5 lines 1 comment Download
M pkg/compiler/lib/src/parser/node_listener.dart View 2 chunks +8 lines, -5 lines 1 comment Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 6 chunks +25 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 5 chunks +22 lines, -5 lines 2 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sra1
https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/parser/element_listener.dart File pkg/compiler/lib/src/parser/element_listener.dart (right): https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/parser/element_listener.dart#newcode273 pkg/compiler/lib/src/parser/element_listener.dart:273: Token implementsKeyword, reformatting https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/parser/node_listener.dart File pkg/compiler/lib/src/parser/node_listener.dart (right): https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/parser/node_listener.dart#newcode106 pkg/compiler/lib/src/parser/node_listener.dart:106: ...
3 years, 10 months ago (2017-02-24 01:01:50 UTC) #4
kevmoo
Yay! I tried switching some PPW const class things (pre enum) to enums and noticed ...
3 years, 10 months ago (2017-02-24 05:52:03 UTC) #6
Johnni Winther
lgtm https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right): https://codereview.chromium.org/2711183002/diff/20001/pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart#newcode116 pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:116: kind = AstKind.ENUM_NAME_FIELD; On 2017/02/24 01:01:50, sra1 wrote: ...
3 years, 10 months ago (2017-02-24 08:52:45 UTC) #7
sra1
3 years, 10 months ago (2017-02-24 23:37:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a22350458bbfd7548c7e4e09175bb7896f89b3ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698