third_party/WebKit/Source/modules/vr/VRDisplay.h - Issue 2711173002: Prevent browser crash resulting from misbehaving WebVR renderer requesting multiple VSyncs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.h

Issue 2711173002: Prevent browser crash resulting from misbehaving WebVR renderer requesting multiple VSyncs. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.h

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.h b/third_party/WebKit/Source/modules/vr/VRDisplay.h

index 5e29e95c13de602b18e4fb0580a9a752d0e29c77..af955c5091b8593e17a0810ed81e71b42581ee3a 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.h

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.h

@@ -136,7 +136,8 @@ class VRDisplay final : public EventTargetWithInlineData,

void OnVSync(device::mojom::blink::VRPosePtr,

mojo::common::mojom::blink::TimeDeltaPtr,

- int16_t frameId);

+ int16_t frameId,

+ device::mojom::blink::VRVSyncProvider::Status);

void ConnectVSyncProvider();

ScriptedAnimationController& ensureScriptedAnimationController(Document*);

@@ -171,6 +172,7 @@ class VRDisplay final : public EventTargetWithInlineData,

Member<ScriptedAnimationController> m_scriptedAnimationController;

bool m_pendingRaf = false;

+ bool m_pendingVsync = false;

bool m_inAnimationFrame = false;

bool m_displayBlurred = false;

bool m_reenteredFullscreen = false;