Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: device/vr/vr_service.mojom

Issue 2711173002: Prevent browser crash resulting from misbehaving WebVR renderer requesting multiple VSyncs. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/vr_service.mojom
diff --git a/device/vr/vr_service.mojom b/device/vr/vr_service.mojom
index 19717b8c5cffa81b52babb983ae5ed7b2221627c..b8c8fa238f3d0293cc1b694af82c34ee4391b98b 100644
--- a/device/vr/vr_service.mojom
+++ b/device/vr/vr_service.mojom
@@ -97,10 +97,16 @@ interface VRDisplay {
};
interface VRVSyncProvider {
+ enum Error {
+ ERROR_NONE,
+ ERROR_TRY_AGAIN,
+ ERROR_BAD_REQUEST,
+ };
+
// The frameId maps a VSync to a frame arriving from the compositor. IDs will
// be reused after the frame arrives from the compositor. Negative IDs imply
// no mapping.
- GetVSync() => (VRPose? pose, mojo.common.mojom.TimeDelta time, int16 frameId);
+ GetVSync() => (VRPose? pose, mojo.common.mojom.TimeDelta time, int16 frameId, Error error);
};
interface VRDisplayClient {

Powered by Google App Engine
This is Rietveld 408576698