Classify more types of input as queries....

Classify more types of input as queries.

This adds an oracle that can determine if a hostname is RFC 1738 compliant; if we get a hostname that's not an IP address and not compliant here, we almost certainly have a query.

This also rejects "ports" that don't consist of a number between 0 and 65535 (e.g. port "abc" or port "123456").

BUG=18817
TEST=The string "foo: bar" (with quotes) should default to search, not navigate, in the address bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29317

[Peter Kasting, 2009-10-16 01:54:10]

Peremptory comment below.

http://codereview.chromium.org/271116/diff/1/5
File chrome/browser/autocomplete/autocomplete.cc (right):

http://codereview.chromium.org/271116/diff/1/5#newcode187
Line 187: (port >= 0) && (port <= 65535)) ? URL : QUERY;
I know you will hate this, but it doesn't really look any better as an if ().

[Paweł Hajdan Jr., 2009-10-16 05:25:01]

Drive-by.

Could you add a test for that, for example in autocomplete_browsertest? This way
we can get the autocomplete tested step by step, at least for new changes.

[brettw, 2009-10-16 16:11:48]

LGTM

[Peter Kasting, 2009-10-16 19:49:12]

On 2009/10/16 05:25:01, Paweł Hajdan Jr. wrote:
> Drive-by.
> 
> Could you add a test for that, for example in autocomplete_browsertest? This
way
> we can get the autocomplete tested step by step, at least for new changes.

Good call.  I actually have a direct unittest of the AutocompleteInput
classifier so I added a few more tests there.

I went ahead and landed this.