Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/cronet/url_request_context_config.cc

Issue 2711153007: Add Cronet experimental option to disable ipv6 (Closed)
Patch Set: oops Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/url_request_context_config.cc
diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc
index 5e1bc351f13c079beaa404ef571bb23fba1b6785..00979d384d94b0122da5b8e70dbfe4c7303e08f5 100644
--- a/components/cronet/url_request_context_config.cc
+++ b/components/cronet/url_request_context_config.cc
@@ -15,6 +15,7 @@
#include "base/strings/string_split.h"
#include "base/values.h"
#include "components/cronet/stale_host_resolver.h"
+#include "net/base/address_family.h"
#include "net/cert/caching_cert_verifier.h"
#include "net/cert/cert_verifier.h"
#include "net/cert/cert_verify_proc.h"
@@ -81,6 +82,11 @@ const char kStaleDnsAllowOtherNetwork[] = "allow_other_network";
const char kHostResolverRulesFieldTrialName[] = "HostResolverRules";
const char kHostResolverRules[] = "host_resolver_rules";
+// Disable IPv6. This should almost never be necessary because the network stack
+// has IPv6 detection logic. Please do not turn on this option without first
+// reporting a bug. See http://crbug.com/696569 for the currently known issue.
+const char kDisableIPv6[] = "disable_ipv6";
+
const char kSSLKeyLogFile[] = "ssl_key_log_file";
void ParseAndSetExperimentalOptions(
@@ -209,6 +215,7 @@ void ParseAndSetExperimentalOptions(
bool async_dns_enable = false;
bool stale_dns_enable = false;
bool host_resolver_rules_enable = false;
+ bool disable_ipv6 = false;
StaleHostResolver::StaleOptions stale_dns_options;
std::string host_resolver_rules_string;
@@ -247,19 +254,24 @@ void ParseAndSetExperimentalOptions(
kHostResolverRules, &host_resolver_rules_string);
}
- if (async_dns_enable || stale_dns_enable || host_resolver_rules_enable) {
+ dict->GetBoolean(kDisableIPv6, &disable_ipv6);
+
+ if (async_dns_enable || stale_dns_enable || host_resolver_rules_enable ||
+ disable_ipv6) {
if (net_log == nullptr) {
- CHECK(false) << "AsyncDNS, StaleDNS, and HostResolverRules experiments "
- << "require NetLog.";
+ CHECK(false) << "All DNS-related experiments require NetLog.";
}
std::unique_ptr<net::HostResolver> host_resolver;
if (stale_dns_enable) {
+ DCHECK(!disable_ipv6);
host_resolver.reset(new StaleHostResolver(
net::HostResolver::CreateDefaultResolverImpl(net_log),
stale_dns_options));
} else {
host_resolver = net::HostResolver::CreateDefaultResolver(net_log);
}
+ if (disable_ipv6)
+ host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4);
if (async_dns_enable)
host_resolver->SetDnsClientEnabled(true);
if (host_resolver_rules_enable) {
« no previous file with comments | « no previous file | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698