Chromium Code Reviews| Index: components/cronet/url_request_context_config.cc |
| diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc |
| index 5e1bc351f13c079beaa404ef571bb23fba1b6785..c64741ba71986b7180fc49a6e4ee52222f0f521f 100644 |
| --- a/components/cronet/url_request_context_config.cc |
| +++ b/components/cronet/url_request_context_config.cc |
| @@ -15,6 +15,7 @@ |
| #include "base/strings/string_split.h" |
| #include "base/values.h" |
| #include "components/cronet/stale_host_resolver.h" |
| +#include "net/base/address_family.h" |
| #include "net/cert/caching_cert_verifier.h" |
| #include "net/cert/cert_verifier.h" |
| #include "net/cert/cert_verify_proc.h" |
| @@ -81,6 +82,11 @@ const char kStaleDnsAllowOtherNetwork[] = "allow_other_network"; |
| const char kHostResolverRulesFieldTrialName[] = "HostResolverRules"; |
| const char kHostResolverRules[] = "host_resolver_rules"; |
| +// Disable IPv6. This should almost never be necessary because the network stack |
| +// has IPv6 detection logic. Please do not turn on this option without first |
| +// reporting a bug. |
|
xunjieli
2017/02/27 15:37:39
nit: Open a bug and link it here.
mgersh
2017/02/28 18:29:57
Done.
|
| +const char kDisableIPv6[] = "disable_ipv6"; |
| + |
| const char kSSLKeyLogFile[] = "ssl_key_log_file"; |
| void ParseAndSetExperimentalOptions( |
| @@ -209,6 +215,7 @@ void ParseAndSetExperimentalOptions( |
| bool async_dns_enable = false; |
| bool stale_dns_enable = false; |
| bool host_resolver_rules_enable = false; |
| + bool disable_ipv6 = false; |
| StaleHostResolver::StaleOptions stale_dns_options; |
| std::string host_resolver_rules_string; |
| @@ -247,10 +254,12 @@ void ParseAndSetExperimentalOptions( |
| kHostResolverRules, &host_resolver_rules_string); |
| } |
| - if (async_dns_enable || stale_dns_enable || host_resolver_rules_enable) { |
| + dict->GetBoolean(kDisableIPv6, &disable_ipv6); |
| + |
| + if (async_dns_enable || stale_dns_enable || host_resolver_rules_enable || |
| + disable_ipv6) { |
| if (net_log == nullptr) { |
| - CHECK(false) << "AsyncDNS, StaleDNS, and HostResolverRules experiments " |
| - << "require NetLog."; |
| + CHECK(false) << "All DNS-related experiments require NetLog."; |
| } |
| std::unique_ptr<net::HostResolver> host_resolver; |
| if (stale_dns_enable) { |
| @@ -260,6 +269,8 @@ void ParseAndSetExperimentalOptions( |
| } else { |
| host_resolver = net::HostResolver::CreateDefaultResolver(net_log); |
| } |
| + if (disable_ipv6) |
| + host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4); |
| if (async_dns_enable) |
| host_resolver->SetDnsClientEnabled(true); |
| if (host_resolver_rules_enable) { |