Adds support for the <keygen> tag for client certificate enrollment...

Adds support for the <keygen> tag for client certificate enrollment
under Linux. Currently, no notifications are given to the user that the
certificate was successfully enrolled.

Patch by Gaurav Shah <gauravsh@chromium.org>; of Google.
Original review URL: http://codereview.chromium.org/261035

BUG=148
TEST=Can test on the following sites:
http://foaf.me/simple_KEYGEN_CreateClientCertificate.php
http://www.myopenid.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29900

[wtc, 2009-10-15 22:13:08]

Gaurav,

I'm preparing your patch for checkin.  Patch Set 1 in this
issue is your Patch Set 8 in http://codereview.chromium.org/261035.

[gauravsh, 2009-10-15 22:38:40]

Just noticed a small bug. Details below. Other than that, looks fine. Also, the
build will probably break since the ChromiumBridge.h file is part of the WebKit
patch and the old one does not include the genKeyAndSignChallenge() function
declaration.

http://codereview.chromium.org/271112/diff/1/18
File net/base/cert_database_nss.cc (right):

http://codereview.chromium.org/271112/diff/1/18#newcode43
Line 43: LOG(ERROR) << "Couldn't create a temporary certificate";
Just noticed a problem here. data_copy will not be deleted it the above
operation fails. The 'delete [] data_copy;' of line 46 can be moved right after
line 41.

[gauravsh, 2009-10-15 22:42:41]

On 2009/10/15 22:38:40, gauravsh wrote:
> Just noticed a small bug. Details below. Other than that, looks fine. Also,
the
> build will probably break since the ChromiumBridge.h file is part of the
WebKit
> patch and the old one does not include the genKeyAndSignChallenge() function
> declaration.

Uhh, I meant the ChromiumBridge class definition doesn't include this new
function. 

> 
> http://codereview.chromium.org/271112/diff/1/18
> File net/base/cert_database_nss.cc (right):
> 
> http://codereview.chromium.org/271112/diff/1/18#newcode43
> Line 43: LOG(ERROR) << "Couldn't create a temporary certificate";
> Just noticed a problem here. data_copy will not be deleted it the above
> operation fails. The 'delete [] data_copy;' of line 46 can be moved right
after
> line 41.

[wtc, 2009-10-15 23:23:30]

Gaurav, please review the delta between Patch Set 1 (yours)
and Patch Set 2.  Thanks.

I will look at the WebKit bug now.

[gauravsh, 2009-10-15 23:34:14]

On 2009/10/15 23:23:30, wtc wrote:
> Gaurav, please review the delta between Patch Set 1 (yours)
> and Patch Set 2.  Thanks.
> 
> I will look at the WebKit bug now.

LGTM.

Can I say that? :)

[wtc, 2009-10-16 22:52:15]

Gaurav,

I uploaded Patch Set 3, which works with the latest WebKit
patch in https://bugs.webkit.org/show_bug.cgi?id=30360.

The genKeyAndSignChallenge method in any "pass through"
class was renamed signedPublicKeyAndChallengeString.

We won't be able to check this in today.  Please work with
the person who will be doing the next WebKit update because
this CL must be checked in at the same time we update to
a WebKit revision that includes your WebKit patch.

Send email to chromium-dev after your WebKit patch is
checked in to find out who will be doing the next WebKit
update.