Chromium Code Reviews
Help | Chromium Project | Sign in
(29)

Issue 271112: Adds support for the <keygen> tag for client certificate enrollment... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
gauravsh
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin
Visibility:
Public.

Description

Adds support for the <keygen> tag for client certificate enrollment
under Linux. Currently, no notifications are given to the user that the
certificate was successfully enrolled.

Patch by Gaurav Shah <gauravsh@chromium.org>; of Google.
Original review URL: http://codereview.chromium.org/261035

BUG=148
TEST=Can test on the following sites:
http://foaf.me/simple_KEYGEN_CreateClientCertificate.php
http://www.myopenid.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29900

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix compilation errors. Fix data_copy leak on error path. Some cleanup. #

Patch Set 3 : Use signedPublicKeyAndChallengeString in ChromiumBridge and WebKitClient #

Patch Set 4 : Minor edits #

Patch Set 5 : Upload before checkin #

Patch Set 6 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+806 lines, -10 lines) Lint Patch
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 2 3 4 5 3 chunks +52 lines, -7 lines 0 comments 1 errors Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/renderer_host/x509_user_cert_resource_handler.h View 1 1 chunk +58 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 1 chunk +100 lines, -0 lines 0 comments 1 errors Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/renderer_webkitclient_impl.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/renderer_webkitclient_impl.cc View 1 2 3 4 5 2 chunks +16 lines, -0 lines 0 comments 1 errors Download
A net/base/cert_database.h View 1 chunk +34 lines, -0 lines 0 comments 1 errors Download
A net/base/cert_database_mac.cc View 1 chunk +24 lines, -0 lines 0 comments 1 errors Download
A net/base/cert_database_nss.cc View 1 1 chunk +102 lines, -0 lines 0 comments 1 errors Download
A net/base/cert_database_win.cc View 1 chunk +24 lines, -0 lines 0 comments 1 errors Download
A net/base/keygen_handler.h View 1 chunk +27 lines, -0 lines 0 comments 1 errors Download
A net/base/keygen_handler_mac.cc View 1 chunk +23 lines, -0 lines 0 comments 1 errors Download
A net/base/keygen_handler_nss.cc View 1 chunk +255 lines, -0 lines 0 comments 1 errors Download
A net/base/keygen_handler_win.cc View 1 chunk +23 lines, -0 lines 0 comments 1 errors Download
M net/base/mime_util.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/net.gyp View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments 0 errors Download
M webkit/api/public/WebKitClient.h View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments 3 errors Download
M webkit/api/src/ChromiumBridge.cpp View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments 1 errors Download
M webkit/glue/webkitclient_impl.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M webkit/glue/webkitclient_impl.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 6
wtc
Gaurav, I'm preparing your patch for checkin. Patch Set 1 in this issue is your ...
4 years, 6 months ago #1
gauravsh
Just noticed a small bug. Details below. Other than that, looks fine. Also, the build ...
4 years, 6 months ago #2
gauravsh
On 2009/10/15 22:38:40, gauravsh wrote: > Just noticed a small bug. Details below. Other than ...
4 years, 6 months ago #3
wtc
Gaurav, please review the delta between Patch Set 1 (yours) and Patch Set 2. Thanks. ...
4 years, 6 months ago #4
gauravsh
On 2009/10/15 23:23:30, wtc wrote: > Gaurav, please review the delta between Patch Set 1 ...
4 years, 6 months ago #5
wtc
4 years, 6 months ago #6
Gaurav,

I uploaded Patch Set 3, which works with the latest WebKit
patch in https://bugs.webkit.org/show_bug.cgi?id=30360.

The genKeyAndSignChallenge method in any "pass through"
class was renamed signedPublicKeyAndChallengeString.

We won't be able to check this in today.  Please work with
the person who will be doing the next WebKit update because
this CL must be checked in at the same time we update to
a WebKit revision that includes your WebKit patch.

Send email to chromium-dev after your WebKit patch is
checked in to find out who will be doing the next WebKit
update.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6