Track whether a given user session has completed initialization, and use

chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Index: chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc b/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
index 6a27aaf1f54acab6c9fee9a68daf619662b114a6..fb5358999bea112d4133b8ad3b4464fdd3337b0d 100644
--- a/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
+++ b/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
@@ -207,9 +207,7 @@ UserPolicyManagerFactoryChromeOS::CreateManagerForProfile(
   const bool block_forever_for_policy =
       !user_manager->IsLoggedInAsStub() &&
       (user_manager->IsCurrentUserNew() ||

[emaxx, 2017/02/23 21:45:25]

IIUC, IsCurrentUserNew() returns true for ephemeral users even during
restart-after-crash. So, even if there IS actually cached policy, we would start
waiting for policy fetch (which, if the policy fetch fails, would terminate the
user session).

Or you planned to implement the fine-grained checks in the policy stack in a
separate CL?

[Andrew T Wilson (Slow), 2017/02/24 16:15:15]

Good point, I'll remove the check for new user as it doesn't buy us anything
(per our discussion). I still plan to put more checks in policy code in a
followup CL, but want to fix this logic now since it fixes a bug.

-       user_manager->GetActiveUser()->force_online_signin() ||
-       user_manager->GetActiveUser()->oauth_token_status() !=
-           user_manager::User::OAUTH2_TOKEN_STATUS_VALID);
+       !user_manager->GetActiveUser()->session_initialized());
 
   const bool wait_for_policy_fetch =
       block_forever_for_policy || !is_browser_restart;