Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2711053004: Fix fasta strong mode errors (and a lint). (Closed)

Created:
3 years, 10 months ago by floitsch
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix fasta strong mode errors (and a lint). Committed: https://github.com/dart-lang/sdk/commit/58550a2efc78026beba8550e621242e7047b0580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/front_end/tool/fasta_perf.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
TBR, since it is one of the reasons the build is red.
3 years, 10 months ago (2017-02-24 13:01:19 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 58550a2efc78026beba8550e621242e7047b0580 (presubmit successful).
3 years, 10 months ago (2017-02-24 13:01:44 UTC) #4
ahe
3 years, 9 months ago (2017-02-27 06:58:07 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698