Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8131)

Unified Diff: chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc

Issue 2711033002: Fix Arc integration test. (Closed)
Patch Set: Pure rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc b/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
index ef5a1c8b50b6ad02513e6327358e45955d0f7d3e..cb4bfa3ce4909041420fc4dc58b02f23f580bb3a 100644
--- a/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
@@ -6,6 +6,8 @@
#include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"
#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h"
+#include "components/arc/arc_util.h"
namespace arc {
@@ -37,8 +39,19 @@ class TwoClientArcPackageSyncTest : public SyncTest {
return sync_helper_ != nullptr;
}
+ void SetUpOnMainThread() override {
+ // This setting does not affect the profile created by InProcessBrowserTest.
+ // Only sync test profiles are affected.
+ ArcAppListPrefsFactory::SetFactoryForSyncTest();
+ }
+
+ // Sets up command line flags required for Arc sync tests.
+ void SetUpCommandLine(base::CommandLine* cl) override {
+ SetArcAvailableCommandLineForTesting(cl);
+ SyncTest::SetUpCommandLine(cl);
+ }
+
void TearDownOnMainThread() override {
- sync_helper_->CleanUp();
sync_helper_ = nullptr;
SyncTest::TearDownOnMainThread();
}
@@ -85,7 +98,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
ASSERT_TRUE(SetupSync());
-
+ ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
}
@@ -108,7 +121,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
ASSERT_TRUE(SetupSync());
-
+ ASSERT_TRUE(AwaitQuiescence());
EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
}
@@ -128,7 +141,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
EXPECT_FALSE(AllProfilesHaveSameArcPackageDetails());
ASSERT_TRUE(SetupSync());
-
+ ASSERT_TRUE(AwaitQuiescence());
EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
}
« no previous file with comments | « chrome/browser/sync/test/integration/sync_arc_package_helper.cc ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698