Fix Arc integration test.

chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc

Index: chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc b/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
index ef5a1c8b50b6ad02513e6327358e45955d0f7d3e..cb4bfa3ce4909041420fc4dc58b02f23f580bb3a 100644
--- a/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
@@ -6,6 +6,8 @@
 #include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"
 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h"
+#include "components/arc/arc_util.h"
 
 namespace arc {
 
@@ -37,8 +39,19 @@ class TwoClientArcPackageSyncTest : public SyncTest {
     return sync_helper_ != nullptr;
   }
 
+  void SetUpOnMainThread() override {
+    // This setting does not affect the profile created by InProcessBrowserTest.

[skym, 2017/03/03 19:44:58]

I don't understand how this comment is true. It seems like this sets a global
static, that is then used every time
ArcAppListPrefsFactory::BuildServiceInstanceFor() is called.

[lgcheng, 2017/03/03 21:13:01]

The ArcAppListPrefs created with InProcessBrowserTest profile seems completed
before this setting from what I read from the log I add, which is good because
it means the sync test global setting doesnot affect non sync test profile.

+    // Only sync test profiles are affected.
+    ArcAppListPrefsFactory::SetFactoryForSyncTest();
+  }
+
+  // Sets up command line flags required for Arc sync tests.
+  void SetUpCommandLine(base::CommandLine* cl) override {
+    SetArcAvailableCommandLineForTesting(cl);
+    SyncTest::SetUpCommandLine(cl);
+  }
+
   void TearDownOnMainThread() override {
-    sync_helper_->CleanUp();
     sync_helper_ = nullptr;
     SyncTest::TearDownOnMainThread();
   }
@@ -85,7 +98,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
   ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
-
+  ASSERT_TRUE(AwaitQuiescence());

[skym, 2017/03/03 19:44:58]

I guess this is okay. I'd prefer you created a derived checker class from
MultiClientStatusChangeChecker and implement IsExitConditionSatisfied() by
calling AllProfilesHaveSameArcPackageDetails(). I'd like to remove
AwaitQuiescence(), but it's fairly low priority.

[lgcheng, 2017/03/03 21:13:01]

Acknowledged.

   ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
@@ -108,7 +121,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
   ASSERT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
-
+  ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
@@ -128,7 +141,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
   EXPECT_FALSE(AllProfilesHaveSameArcPackageDetails());
 
   ASSERT_TRUE(SetupSync());
-
+  ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }