Fix Arc integration test.

chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"
 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h"
 
 namespace arc {
 
 namespace {
 
 bool AllProfilesHaveSameArcPackageDetails() {
   return SyncArcPackageHelper::GetInstance()
       ->AllProfilesHaveSamePackageDetails();
 }
 
@@ skipping 11 matching lines @@
   bool SetupClients() override {
     if (!SyncTest::SetupClients())
       return false;
 
     // Init SyncArcPackageHelper to ensure that the arc services are initialized
     // for each Profile.
     sync_helper_ = SyncArcPackageHelper::GetInstance();
     return sync_helper_ != nullptr;
   }
 
+  void SetUpOnMainThread() override {
+    ArcAppListPrefsFactory::SetFactoryForSyncTest();

[hidehiko, 2017/02/23 06:31:45]

This runs after initial profile creation.
Is it expected? If so, better to comment, I think.

[lgcheng, 2017/02/23 18:27:05]

When you mentioned initial profile, did you mean the browser_test base profile?
That profile is not used in this sync test and it is just used to set up the
browser test environment. Sync test create another 2 profiles and syncs data
between them. All these workaround is to make the 2 sync_test related profiles
can get through our ARC logic and do not cause crash during shut down of
browser_test base profile.

[hidehiko, 2017/02/23 19:12:24]

Yes.

I know it is not interesting for the test cases. However, it is actually created
at first, and this global config is set after that.
That means, the initial profile is created in the different manner from ones
created later for actual testing.
So, I thought it's better to comment about it to avoid confusing for future
readers.

+  }
+
   void TearDownOnMainThread() override {
     sync_helper_->CleanUp();
     sync_helper_ = nullptr;
     SyncTest::TearDownOnMainThread();
   }
 
   SyncArcPackageHelper* sync_helper() { return sync_helper_; }
 
  private:
   SyncArcPackageHelper* sync_helper_;
@@ skipping 119 matching lines @@
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 
   sync_helper()->UninstallPackageWithIndex(GetProfile(1), 1);
   EXPECT_FALSE(AllProfilesHaveSameArcPackageDetails());
   ASSERT_TRUE(AwaitQuiescence());
   EXPECT_TRUE(AllProfilesHaveSameArcPackageDetails());
 }
 
 }  // namespace arc