third_party/WebKit/Source/web/ContextMenuClientImpl.cpp - Issue 2710983003: Move HistoryItem handling to DocumentLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2710983003: Move HistoryItem handling to DocumentLoader (Closed)

Patch Set: Address kinuko's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

index dd9e57e9fe261a56dc41a8e0ea49eab7eefec896..701d204c2be30d0c1996c3cd483314d17ca018c3 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

@@ -301,7 +301,8 @@ bool ContextMenuClientImpl::showContextMenu(const ContextMenu* defaultMenu,

if (selectedFrame != m_webView->page()->mainFrame()) {

data.frameURL = urlFromFrame(selectedFrame);

- HistoryItem* historyItem = selectedFrame->loader().currentItem();

+ HistoryItem* historyItem =

+ selectedFrame->loader().documentLoader()->historyItem();

if (historyItem)

data.frameHistoryItem = WebHistoryItem(historyItem);

}