Move HistoryItem handling to DocumentLoader

third_party/WebKit/Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1634 matching lines @@
   EXPECT_EQ(0, webViewImpl->mainFrame()->getScrollOffset().height);
 
   // Make the page scale and scroll with the given paremeters.
   webViewImpl->setPageScaleFactor(2.0f);
   webViewImpl->mainFrame()->setScrollOffset(WebSize(94, 111));
   EXPECT_EQ(2.0f, webViewImpl->pageScaleFactor());
   EXPECT_EQ(94, webViewImpl->mainFrame()->getScrollOffset().width);
   EXPECT_EQ(111, webViewImpl->mainFrame()->getScrollOffset().height);
   LocalFrame* mainFrameLocal = toLocalFrame(webViewImpl->page()->mainFrame());
   mainFrameLocal->loader().saveScrollState();
-  EXPECT_EQ(2.0f, mainFrameLocal->loader().currentItem()->pageScaleFactor());
-  EXPECT_EQ(94,
-            mainFrameLocal->loader().currentItem()->getScrollOffset().width());
-  EXPECT_EQ(111,
-            mainFrameLocal->loader().currentItem()->getScrollOffset().height());
+  EXPECT_EQ(2.0f, mainFrameLocal->loader()
+                      .documentLoader()
+                      ->historyItem()
+                      ->pageScaleFactor());
+  EXPECT_EQ(94, mainFrameLocal->loader()
+                    .documentLoader()
+                    ->historyItem()
+                    ->getScrollOffset()
+                    .width());
+  EXPECT_EQ(111, mainFrameLocal->loader()
+                     .documentLoader()
+                     ->historyItem()
+                     ->getScrollOffset()
+                     .height());
 
   // Confirm that resetting the page state resets the saved scroll position.
   webViewImpl->resetScrollAndScaleState();
   EXPECT_EQ(1.0f, webViewImpl->pageScaleFactor());
   EXPECT_EQ(0, webViewImpl->mainFrame()->getScrollOffset().width);
   EXPECT_EQ(0, webViewImpl->mainFrame()->getScrollOffset().height);
-  EXPECT_EQ(1.0f, mainFrameLocal->loader().currentItem()->pageScaleFactor());
-  EXPECT_EQ(0,
-            mainFrameLocal->loader().currentItem()->getScrollOffset().width());
-  EXPECT_EQ(0,
-            mainFrameLocal->loader().currentItem()->getScrollOffset().height());
+  EXPECT_EQ(1.0f, mainFrameLocal->loader()
+                      .documentLoader()
+                      ->historyItem()
+                      ->pageScaleFactor());
+  EXPECT_EQ(0, mainFrameLocal->loader()
+                   .documentLoader()
+                   ->historyItem()
+                   ->getScrollOffset()
+                   .width());
+  EXPECT_EQ(0, mainFrameLocal->loader()
+                   .documentLoader()
+                   ->historyItem()
+                   ->getScrollOffset()
+                   .height());
 }
 
 TEST_P(WebViewTest, BackForwardRestoreScroll) {
   registerMockedHttpURLLoad("back_forward_restore_scroll.html");
   WebViewImpl* webViewImpl = m_webViewHelper.initializeAndLoad(
       m_baseURL + "back_forward_restore_scroll.html");
   webViewImpl->resize(WebSize(640, 480));
   webViewImpl->updateAllLifecyclePhases();
 
   // Emulate a user scroll
   webViewImpl->mainFrame()->setScrollOffset(WebSize(0, 900));
   LocalFrame* mainFrameLocal = toLocalFrame(webViewImpl->page()->mainFrame());
-  Persistent<HistoryItem> item1 = mainFrameLocal->loader().currentItem();
+  Persistent<HistoryItem> item1 =
+      mainFrameLocal->loader().documentLoader()->historyItem();
 
   // Click an anchor
   mainFrameLocal->loader().load(FrameLoadRequest(
       mainFrameLocal->document(),
       ResourceRequest(mainFrameLocal->document()->completeURL("#a"))));
-  Persistent<HistoryItem> item2 = mainFrameLocal->loader().currentItem();
+  Persistent<HistoryItem> item2 =
+      mainFrameLocal->loader().documentLoader()->historyItem();
 
   // Go back, then forward, then back again.
   mainFrameLocal->loader().load(
-      FrameLoadRequest(
-          nullptr, FrameLoader::resourceRequestFromHistoryItem(
-                       item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
+      FrameLoadRequest(nullptr, item1->generateResourceRequest(
+                                    WebCachePolicy::UseProtocolCachePolicy)),
       FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
   mainFrameLocal->loader().load(
-      FrameLoadRequest(
-          nullptr, FrameLoader::resourceRequestFromHistoryItem(
-                       item2.get(), WebCachePolicy::UseProtocolCachePolicy)),
+      FrameLoadRequest(nullptr, item2->generateResourceRequest(
+                                    WebCachePolicy::UseProtocolCachePolicy)),
       FrameLoadTypeBackForward, item2.get(), HistorySameDocumentLoad);
   mainFrameLocal->loader().load(
-      FrameLoadRequest(
-          nullptr, FrameLoader::resourceRequestFromHistoryItem(
-                       item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
+      FrameLoadRequest(nullptr, item1->generateResourceRequest(
+                                    WebCachePolicy::UseProtocolCachePolicy)),
       FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
 
   // Click a different anchor
   mainFrameLocal->loader().load(FrameLoadRequest(
       mainFrameLocal->document(),
       ResourceRequest(mainFrameLocal->document()->completeURL("#b"))));
-  Persistent<HistoryItem> item3 = mainFrameLocal->loader().currentItem();
+  Persistent<HistoryItem> item3 =
+      mainFrameLocal->loader().documentLoader()->historyItem();
 
   // Go back, then forward. The scroll position should be properly set on the
   // forward navigation.
   mainFrameLocal->loader().load(
-      FrameLoadRequest(
-          nullptr, FrameLoader::resourceRequestFromHistoryItem(
-                       item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
+      FrameLoadRequest(nullptr, item1->generateResourceRequest(
+                                    WebCachePolicy::UseProtocolCachePolicy)),
       FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
   mainFrameLocal->loader().load(
-      FrameLoadRequest(
-          nullptr, FrameLoader::resourceRequestFromHistoryItem(
-                       item3.get(), WebCachePolicy::UseProtocolCachePolicy)),
+      FrameLoadRequest(nullptr, item3->generateResourceRequest(
+                                    WebCachePolicy::UseProtocolCachePolicy)),
       FrameLoadTypeBackForward, item3.get(), HistorySameDocumentLoad);
   EXPECT_EQ(0, webViewImpl->mainFrame()->getScrollOffset().width);
   EXPECT_GT(webViewImpl->mainFrame()->getScrollOffset().height, 2000);
 }
 
 // Tests that we restore scroll and scale *after* the fullscreen styles are
 // removed and the page is laid out. http://crbug.com/625683.
 TEST_P(WebViewTest, FullscreenResetScrollAndScaleFullscreenStyles) {
   registerMockedHttpURLLoad("fullscreen_style.html");
   WebViewImpl* webViewImpl =
@@ skipping 2693 matching lines @@
   EXPECT_FALSE(frameView->visualViewportSuppliesScrollbars());
   if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
     EXPECT_NE(nullptr,
               frameView->layoutViewportScrollableArea()->verticalScrollbar());
   } else {
     EXPECT_NE(nullptr, frameView->verticalScrollbar());
   }
 }
 
 }  // namespace blink