Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2710973002: Revert "Add support for the new function-type syntax." (Closed)

Created:
3 years, 10 months ago by floitsch
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add support for the new function-type syntax." This reverts commit c289af39c36d9a5f7130a3e69b7891052652a64e. BUG= Committed: https://github.com/dart-lang/sdk/commit/c66479f40767744d0bdd027c004583d6e32fe50f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -1735 lines) Patch
M .packages View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -10 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 3 chunks +2 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 5 chunks +9 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 3 chunks +6 lines, -53 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 6 chunks +6 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 10 chunks +15 lines, -193 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 4 chunks +3 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 18 chunks +14 lines, -95 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 4 chunks +7 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 3 chunks +3 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/error_kind.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 3 chunks +5 lines, -22 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 16 chunks +46 lines, -230 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 3 chunks +5 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/keyword.dart View 8 chunks +17 lines, -57 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
D pkg/front_end/test/fasta/function_type_recovery_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
D tests/language/function_type/test_generator.dart View 1 chunk +0 lines, -770 lines 0 comments Download
D tests/language/generic_function_typedef2_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/generic_function_typedef_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR.
3 years, 10 months ago (2017-02-22 16:19:17 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as c66479f40767744d0bdd027c004583d6e32fe50f (presubmit successful).
3 years, 10 months ago (2017-02-22 16:19:43 UTC) #4
ahe
LGTM :-( Why did you have to revert?
3 years, 9 months ago (2017-02-27 08:24:16 UTC) #5
floitsch
3 years, 9 months ago (2017-02-27 09:55:46 UTC) #6
Message was sent while issue was closed. 
On 2017/02/27 08:24:16, ahe wrote:
> LGTM :-(
> 
> Why did you have to revert?

Temporary revert because the analyzer also started to depend on fasta and I had
to change their code too.

Powered by Google App Engine
This is Rietveld 408576698