Add metrics for quantity and type of Favicon candidates

components/favicon/core/favicon_driver_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_driver_impl.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 #include "build/build_config.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/favicon/core/favicon_driver_observer.h"
 #include "components/favicon/core/favicon_handler.h"
 #include "components/favicon/core/favicon_service.h"
+#include "components/favicon/core/favicon_url.h"
 #include "components/history/core/browser/history_service.h"
 
 namespace favicon {
 namespace {
 
 #if defined(OS_ANDROID) || defined(OS_IOS)
 const bool kEnableTouchIcon = true;
 #else
 const bool kEnableTouchIcon = false;
 #endif
 
+void RecordCandidateMetrics(const std::vector<FaviconURL>& candidates) {
+  UMA_HISTOGRAM_COUNTS_100("Favicons.CandidatesCount", candidates.size());

[pkotwicz, 2017/02/27 18:54:57]

Nit: Put this metric together with the other metrics at the bottom of the
function

[fhorschig, 2017/03/01 20:56:01]

Done.

+  size_t with_defined_touch_icons = 0;
+  size_t with_defined_sizes = 0;
+  for (const auto& candidate : candidates) {
+    if (!candidate.icon_sizes.empty()) {
+      with_defined_sizes++;
+    }
+    if (candidate.icon_type &
+        (favicon_base::IconType::TOUCH_ICON |
+         favicon_base::IconType::TOUCH_PRECOMPOSED_ICON)) {
+      with_defined_touch_icons++;
+    }
+  }
+  UMA_HISTOGRAM_COUNTS_100("Favicons.CandidatesWithDefinedSizesCount",
+                           with_defined_sizes);
+  UMA_HISTOGRAM_COUNTS_100("Favicons.CandidatesWithLargeIconsCount",

[pkotwicz, 2017/02/27 18:54:57]

Nit: Maybe rename to CandidatesWithTouchIconsCount?

[fhorschig, 2017/03/01 20:56:01]

Done.

+                           with_defined_touch_icons);
+}
+
 }  // namespace
 
 FaviconDriverImpl::FaviconDriverImpl(FaviconService* favicon_service,
                                      history::HistoryService* history_service,
                                      bookmarks::BookmarkModel* bookmark_model)
     : favicon_service_(favicon_service),
       history_service_(history_service),
       bookmark_model_(bookmark_model) {
   favicon_handler_.reset(new FaviconHandler(
       favicon_service_, this, kEnableTouchIcon
@@ skipping 56 matching lines @@
     favicon_service_->SetFaviconOutOfDateForPage(url);
     if (force_reload)
       favicon_service_->ClearUnableToDownloadFavicons();
   }
 }
 
 void FaviconDriverImpl::OnUpdateFaviconURL(
     const GURL& page_url,
     const std::vector<FaviconURL>& candidates) {
   DCHECK(!candidates.empty());
+  RecordCandidateMetrics(candidates);
   favicon_handler_->OnUpdateFaviconURL(page_url, candidates);
   if (touch_icon_handler_.get())
     touch_icon_handler_->OnUpdateFaviconURL(page_url, candidates);
 }
 
 }  // namespace favicon