Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-23T16:27:43 rebase to resolve conflict with DOMSelection in r452402 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 64e2af8a2e923aed9d6cd694a9e3f53af4d04ebe..6ab6f1809a29f36d31897ab7a981c0805ff3364b 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2356,7 +2356,8 @@ bool WebViewImpl::selectionBounds(WebRect& anchor, WebRect& focus) const {
if (!localFrame)
return false;
FrameSelection& selection = localFrame->selection();
- if (!selection.isAvailable() || selection.isNone()) {
+ if (!selection.isAvailable() ||
+ selection.computeVisibleSelectionInDOMTreeDeprecated().isNone()) {
// plugins/mouse-capture-inside-shadow.html reaches here.
return false;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698