third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-23T16:27:43 rebase to resolve conflict with DOMSelection in r452402 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index 2e8a12df037fd6b5886b930713f5009ac1964cce..f672dce6982d36352fbaaaf570b637bd852fb5a4 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -190,10 +190,6 @@ class CORE_EXPORT FrameSelection final

void didChangeFocus();

const SelectionInDOMTree& selectionInDOMTree() const;

- // TODO(yosin): We should rename |isNone()| to |isVisibleNone()|.

- bool isNone() const {

- return computeVisibleSelectionInDOMTreeDeprecated().isNone();

- }

bool isInPasswordField() const;

bool isDirectional() const { return selectionInDOMTree().isDirectional(); }