Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 45 matching lines @@
   return text;
 }
 
 TEST_F(FrameSelectionTest, SetValidSelection) {
   Text* text = appendTextNode("Hello, World!");
   document().view()->updateAllLifecyclePhases();
   selection().setSelection(
       SelectionInDOMTree::Builder()
           .setBaseAndExtent(Position(text, 0), Position(text, 5))
           .build());
-  EXPECT_FALSE(selection().isNone());
+  EXPECT_FALSE(
+      selection().computeVisibleSelectionInDOMTreeDeprecated().isNone());
 }
 
 TEST_F(FrameSelectionTest, PaintCaretShouldNotLayout) {
   Text* text = appendTextNode("Hello, World!");
   document().view()->updateAllLifecyclePhases();
 
   document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
   document().body()->focus();
   EXPECT_TRUE(document().body()->isFocused());
 
@@ skipping 124 matching lines @@
   selection().moveRangeSelection(createVisiblePosition(Position(text, 5)),
                                  createVisiblePosition(Position(text, 2)),
                                  WordGranularity);
   EXPECT_EQ_SELECTED_TEXT("Foo Bar");
 }
 
 TEST_F(FrameSelectionTest, SelectAllWithUnselectableRoot) {
   Element* select = document().createElement("select");
   document().replaceChild(select, document().documentElement());
   selection().selectAll();
-  EXPECT_TRUE(selection().isNone()) << "Nothing should be selected if the "
-                                       "content of the documentElement is not "
-                                       "selctable.";
+  EXPECT_TRUE(selection().computeVisibleSelectionInDOMTreeDeprecated().isNone())
+      << "Nothing should be selected if the "
+         "content of the documentElement is not "
+         "selctable.";
 }
 
 TEST_F(FrameSelectionTest, SelectAllPreservesHandle) {
   setBodyContent("<div id=sample>abc</div>");
   Element* sample = document().getElementById("sample");
   const Position endOfText(sample->firstChild(), 3);
   selection().setSelection(SelectionInDOMTree::Builder()
                                .collapse(endOfText)
                                .setIsHandleVisible(false)
                                .build());
@@ skipping 37 matching lines @@
   selection().updateIfNeeded();
 
   EXPECT_EQ(Position(),
             selection().computeVisibleSelectionInDOMTreeDeprecated().start())
       << "selection().updateIfNeeded() does nothing.";
   EXPECT_EQ(selection().computeVisibleSelectionInDOMTreeDeprecated().start(),
             caretPosition().position());
 }
 
 }  // namespace blink