Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 271083002: Resource Timing: Use original Timing-Allow-Origin for cache validating (Closed)

Created:
6 years, 7 months ago by bashi
Modified:
6 years, 7 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Resource Timing: Use original Timing-Allow-Origin for cache validating For 304 responses, we need to check the Timing-Allow-Origin header of the original response. Even though we keep the original response during revalidation, it isn't available at the time passesTimingAllowCheck() evaluates the final response. This CL makes ResourceTimingInfo keep the original value of the Timing-Allow-Origin header so that passesTimingAllowCheck() can refer the original value. BUG=368966 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173813

Patch Set 1 #

Patch Set 2 : Add tst #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -5 lines) Patch
A LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/resource-timing-details-for-revalidation-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/resources/cors-ahem.php View 1 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/timing/Performance.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/timing/ResourceTimingInfo.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bashi
Hi japhet@, could you take a look?
6 years, 7 months ago (2014-05-09 10:53:32 UTC) #1
Nate Chapin
LGTM. Test?
6 years, 7 months ago (2014-05-09 16:43:20 UTC) #2
bashi
On 2014/05/09 16:43:20, Nate Chapin wrote: > LGTM. Test? Thanks! Added a test. Could you ...
6 years, 7 months ago (2014-05-10 01:14:51 UTC) #3
Nate Chapin
LGTM with a nit. Thanks! https://codereview.chromium.org/271083002/diff/20001/LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html File LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html (right): https://codereview.chromium.org/271083002/diff/20001/LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html#newcode23 LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html:23: testRunner.waitUntilDone(); I'd put this ...
6 years, 7 months ago (2014-05-10 02:16:40 UTC) #4
bashi
https://codereview.chromium.org/271083002/diff/20001/LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html File LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html (right): https://codereview.chromium.org/271083002/diff/20001/LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html#newcode23 LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html:23: testRunner.waitUntilDone(); On 2014/05/10 02:16:40, Nate Chapin wrote: > I'd ...
6 years, 7 months ago (2014-05-10 02:41:07 UTC) #5
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 7 months ago (2014-05-10 02:41:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/271083002/40001
6 years, 7 months ago (2014-05-10 02:42:10 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 03:59:17 UTC) #8
Message was sent while issue was closed.
Change committed as 173813

Powered by Google App Engine
This is Rietveld 408576698