[sql] RecoverDatabase() deletes SQLITE_NOTADB databases.

sql/recovery_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sql/recovery.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 787 matching lines @@
 
   // Test that the trigger works.
   ASSERT_TRUE(db().Execute("DELETE FROM x WHERE v = 'truck'"));
   EXPECT_EQ("1|turtle\n3|trailer",
             ExecuteWithResults(&db(), kXSql, "|", "\n"));
   EXPECT_EQ("dean|trailer\njim|telephone",
             ExecuteWithResults(&db(), kYSql, "|", "\n"));
   EXPECT_EQ("trailer", ExecuteWithResults(&db(), kVSql, "|", "\n"));
 }
 
+// When RecoverDatabase() encounters SQLITE_NOTADB, the database is deleted.
+TEST_F(SQLRecoveryTest, RecoverDatabaseDelete) {
+  // Create a valid database, then write junk over the header.  This should lead
+  // to SQLITE_NOTADB, which will cause ATTACH to fail.
+  ASSERT_TRUE(db().Execute("CREATE TABLE x (t TEXT)"));
+  ASSERT_TRUE(db().Execute("INSERT INTO x VALUES ('This is a test')"));
+  db().Close();
+  WriteJunkToDatabase(SQLTestBase::TYPE_OVERWRITE);
+
+  {
+    sql::test::ScopedErrorExpecter expecter;
+    expecter.ExpectError(SQLITE_NOTADB);
+
+    // Reopen() here because it will see SQLITE_NOTADB.
+    ASSERT_TRUE(Reopen());
+
+    // This should "recover" the database by making it valid, but empty.
+    sql::Recovery::RecoverDatabase(&db(), db_path());
+
+    ASSERT_TRUE(expecter.SawExpectedErrors());
+  }
+
+  // Recovery poisoned the handle, must re-open.
+  db().Close();
+  ASSERT_TRUE(Reopen());
+
+  EXPECT_EQ("", GetSchema(&db()));
+}
+
 // Test histograms recorded when the invalid database cannot be attached.
 TEST_F(SQLRecoveryTest, AttachFailure) {
   // Create a valid database, then write junk over the header.  This should lead
   // to SQLITE_NOTADB, which will cause ATTACH to fail.
   ASSERT_TRUE(db().Execute("CREATE TABLE x (t TEXT)"));
   ASSERT_TRUE(db().Execute("INSERT INTO x VALUES ('This is a test')"));
   db().Close();
   WriteJunkToDatabase(SQLTestBase::TYPE_OVERWRITE);
 
   const char kEventHistogramName[] = "Sqlite.RecoveryEvents";
@@ skipping 86 matching lines @@
   EXPECT_NO_FATAL_FAILURE(TestPageSize(db_path(), 1024, "1024", 1024, "1024"));
 
   // Databases with no page size specified should recover with the new default
   // page size.  2k has never been the default page size.
   ASSERT_NE("2048", default_page_size);
   EXPECT_NO_FATAL_FAILURE(
       TestPageSize(db_path(), 2048, "2048", 0, default_page_size));
 }
 
 }  // namespace