Issue 271081: Pad time to next audio data write to compensate for nanosleep inaccuracy on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271081: Pad time to next audio data write to compensate for nanosleep inaccuracy on linux. (Closed)

Created:
11 years, 2 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing), Alpha Left Google

CC:
chromium-reviews_googlegroups.com, Markus (顧孟勤)

Visibility:
Public.

Description

Pad time to next audio data write to compensate for nanosleep inaccuracy on linux. Nanosleep on linux can miss its deadline by up to 10ms (according to the manpage). Pad 20ms (2x that amount) to give room for missed deadlines. BUG=23974 TEST=listened to previously stuttering audio clip on low-end hardware.

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	media/audio/linux/alsa_output.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

LGTM -- sorry for delay

Expand Messages | Collapse Messages