Pass '=' to endNamedMixinApplication().

Pass '=' to endNamedMixinApplication().

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3fda231b1a8ac483fe32028379f7983cc74e5181

[ahe, 2017-02-21 18:44:06]

You also need to make this change to dart2js.

I'll send you a command for running dart2js tests.

Otherwise, this is nice.

[ahe, 2017-02-21 18:48:00]

Testing dart2js:

gclient sync && ./tools/build.py --mode release --arch x64 runtime create_sdk &&
./out/ReleaseX64/dart pkg/testing/bin/testing.dart
--config=pkg/front_end/test/fasta/testing.json dart2js

You're particularly interested in the listeners in pkg/compiler/lib/src/parser/.

[scheglov, 2017-02-21 19:05:48]

PTAL

It seems that it is almost impossible for me to run all dart2js tests. The first
40 tests took about 70 seconds. And there are 17000+ of them. So running all the
tests would take about 8 hours.

[Paul Berry, 2017-02-21 19:12:23]

lgtm.

I assume dart2js is adequately tested by the buildbots?  This is a pretty low
risk change, so assuming that it is, I think it is ok to commit as is and then
follow up with a fix (or a revert) if it causes a dart2js failure.

[scheglov, 2017-02-21 21:37:09]

Description was changed from

==========
Pass '=' to endNamedMixinApplication().

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Pass '=' to endNamedMixinApplication().

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3fda231b1a8ac483fe32028379f7983cc74e5181
==========

[scheglov, 2017-02-21 21:37:10]

Committed patchset #2 (id:20001) manually as
3fda231b1a8ac483fe32028379f7983cc74e5181 (presubmit successful).

[ahe, 2017-02-22 05:22:51]

On 2017/02/21 19:05:48, scheglov wrote:
> PTAL
> 
> It seems that it is almost impossible for me to run all dart2js tests. The
first
> 40 tests took about 70 seconds. And there are 17000+ of them. So running all
the
> tests would take about 8 hours.

What kind of machine are you running tests on? It sounds like you don't have the
adequate hardware.

Fortunately, you can't extrapolate from the first 40 tests, those are really
slow.

[scheglov, 2017-02-22 05:28:09]

On 2017/02/22 05:22:51, ahe wrote:
> On 2017/02/21 19:05:48, scheglov wrote:
> > PTAL
> > 
> > It seems that it is almost impossible for me to run all dart2js tests. The
> first
> > 40 tests took about 70 seconds. And there are 17000+ of them. So running all
> the
> > tests would take about 8 hours.
> 
> What kind of machine are you running tests on? It sounds like you don't have
the
> adequate hardware.

MacBook Pro (Retina, 15-inch, Mid 2015)

> 
> Fortunately, you can't extrapolate from the first 40 tests, those are really
> slow.

[ahe, 2017-02-22 05:34:46]

On 2017/02/21 19:12:23, Paul Berry wrote:
> lgtm.
> 
> I assume dart2js is adequately tested by the buildbots?  This is a pretty low
> risk change, so assuming that it is, I think it is ok to commit as is and then
> follow up with a fix (or a revert) if it causes a dart2js failure.

I agree that this is a low risk change, however, you need to be able to run
dart2js tests. I'll be happy to help you get set up.

In general, you can't use the build bots as try bots. Doing so has a huge impact
on your co-workers' productivity. You should be able to run the tests in about
30 minutes, whereas breaking dart2js can easily cost your co-workers ten times
that.

[ahe, 2017-02-22 05:35:54]

lgtm

https://codereview.chromium.org/2710803002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2710803002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:845: Token beginToken,
Token equalsToken, Token implementsKeyword, Token endToken) {
Long line.