Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2710783004: Fix two issues with modular compilation in dartk. (Closed)

Created:
3 years, 10 months ago by asgerf
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix two issues with modular compilation in dartk. - The interface for a factory constructor in an external library would reference the class type parameters instead of its own. - When a class from an external library gets promoted to mixin level, the rest of the library should not be considered "being loaded". This would cause members to not get added to the AST. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/2f331ecd1b0da7df535b6314c5249fef40916370

Patch Set 1 #

Patch Set 2 : Add test case that would fail in modular compilation #

Patch Set 3 : Fix test case #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/kernel/lib/analyzer/loader.dart View 5 chunks +9 lines, -2 lines 0 comments Download
A tests/language/mixin_class_from_core_library_test.dart View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 10 months ago (2017-02-22 15:21:17 UTC) #2
Kevin Millikin (Google)
lgtm
3 years, 10 months ago (2017-02-23 11:09:36 UTC) #3
asgerf
3 years, 10 months ago (2017-02-23 11:38:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2f331ecd1b0da7df535b6314c5249fef40916370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698