Fix PreferenceConnectionManagerTeardown

chrome/browser/prefs/preferences_connection_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/preferences_connection_manager.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/preferences_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 25 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ShutdownNotifierFactory);
 };
 
 }  // namespace
 
 PreferencesConnectionManager::PreferencesConnectionManager() {}
 
 PreferencesConnectionManager::~PreferencesConnectionManager() {}
 
-void PreferencesConnectionManager::OnConnectionError(
-    mojo::StrongBindingPtr<prefs::mojom::PreferencesService> binding) {
-  if (!binding)
-    return;
-  for (auto it = manager_bindings_.begin(); it != manager_bindings_.end();
-       ++it) {
-    if (it->get() == binding.get()) {
-      manager_bindings_.erase(it);
-      return;
-    }
-  }
-}
-
 void PreferencesConnectionManager::OnProfileDestroyed() {
-  for (auto& it : manager_bindings_) {
-    // Shutdown any PreferenceManager that is still alive.
-    if (it)
-      it->Close();
-  }
-
+  // Shutdown any PreferenceService that is still alive.
+  manager_bindings_.CloseAllBindings();
   profile_shutdown_notification_.reset();
 }
 
 void PreferencesConnectionManager::Create(
     prefs::mojom::PreferencesServiceClientPtr client,
     prefs::mojom::PreferencesServiceRequest service) {
   // Certain tests have no profiles to connect to, and static initializers
   // which block the creation of test profiles.
   if (!g_browser_process->profile_manager()->GetNumberOfProfiles())
     return;
 
-  Profile* profile = ProfileManager::GetActiveUserProfile();
-  mojo::StrongBindingPtr<prefs::mojom::PreferencesService> binding =
-      mojo::MakeStrongBinding(
-          base::MakeUnique<PreferencesService>(std::move(client), profile),
-          std::move(service));
-  // Copying the base::WeakPtr for future deletion.
-  binding->set_connection_error_handler(
-      base::Bind(&PreferencesConnectionManager::OnConnectionError,
-                 base::Unretained(this), binding));
-  manager_bindings_.push_back(std::move(binding));
+  manager_bindings_.AddBinding(
+      base::MakeUnique<PreferencesService>(
+          std::move(client), ProfileManager::GetActiveUserProfile()),
+      std::move(service));
 }
 
 void PreferencesConnectionManager::Create(
     const service_manager::Identity& remote_identity,
     prefs::mojom::PreferencesServiceFactoryRequest request) {
   factory_bindings_.AddBinding(this, std::move(request));
 
   if (!profile_shutdown_notification_) {
     profile_shutdown_notification_ =
         ShutdownNotifierFactory::GetInstance()
             ->Get(ProfileManager::GetActiveUserProfile())
             ->Subscribe(
                 base::Bind(&PreferencesConnectionManager::OnProfileDestroyed,
                            base::Unretained(this)));
   }
 }
 
-void PreferencesConnectionManager::OnStart() {
-  // Certain tests have no profiles to connect to, and static initializers
-  // which block the creation of test profiles.
-  if (!g_browser_process->profile_manager()->GetNumberOfProfiles())
-    return;
-}

[jonross, 2017/02/21 15:55:54]

The functionality that was here was moved to Create (line 94-100 above)

So its no longer needed

-
 bool PreferencesConnectionManager::OnConnect(
     const service_manager::ServiceInfo& remote_info,
     service_manager::InterfaceRegistry* registry) {
   registry->AddInterface<prefs::mojom::PreferencesServiceFactory>(this);
   return true;
 }