Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3455)

Unified Diff: cc/ipc/display_compositor.mojom

Issue 2710703005: GpuDisplayCompositorFrameSink => GpuRootCompositorFrameSink (Closed)
Patch Set: Addressed Dana's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/display_compositor/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/display_compositor.mojom
diff --git a/cc/ipc/display_compositor.mojom b/cc/ipc/display_compositor.mojom
index bd0e942844edfe09cbbf536c53f06dcdc64c16a4..52b688aafd62cd930c54aa99de03ad63e015d645 100644
--- a/cc/ipc/display_compositor.mojom
+++ b/cc/ipc/display_compositor.mojom
@@ -40,8 +40,8 @@ interface DisplayPrivate {
interface DisplayCompositor {
// Create a CompositorFrameSink for a privileged client (e.g. WindowServer).
// This is only used by privileged clients. The client can call methods that
- // talks to the cc::Display (e.g. ResizeDisplay(), SetDisplayVisible(), etc)
- CreateDisplayCompositorFrameSink(
+ // talks to the Display (e.g. ResizeDisplay(), SetDisplayVisible(), etc)
+ CreateRootCompositorFrameSink(
cc.mojom.FrameSinkId frame_sink_id,
gpu.mojom.SurfaceHandle widget,
associated cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,
@@ -49,10 +49,10 @@ interface DisplayCompositor {
cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client,
associated DisplayPrivate& display_private);
- // CreateOffscreenCompositorFrameSink is used by unprivileged clients.
- // An off screen CompositorFrameSink only submits frames to a buffer instead
- // of a display.
- CreateOffscreenCompositorFrameSink(
+ // CreateCompositorFrameSink is used by unprivileged clients.
+ // This CompositorFrameSink is not a root, and has to be parented by another
+ // CompositorFrameSink in order to appear on screen.
+ CreateCompositorFrameSink(
cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,
cc.mojom.MojoCompositorFrameSinkPrivate& compositor_frame_sink_private,
« no previous file with comments | « no previous file | components/display_compositor/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698