ios/chrome/browser/payments/shipping_option_selection_view_controller.mm - Issue 2710683012: [Payment Request] Payment request summary view pending state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

Issue 2710683012: [Payment Request] Payment request summary view pending state (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/payments/payment_request_view_controller.h ('K') | « ios/chrome/browser/payments/shipping_option_selection_view_controller.h ('k') | ios/chrome/browser/payments/shipping_option_selection_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

diff --git a/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm b/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

index 9abf8dc0034f9bcfecfe0b1d8c2cfc3bd2c77d86..70f0d5f76ccabc3434526257645ce6e369dff8be 100644

--- a/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

+++ b/ios/chrome/browser/payments/shipping_option_selection_view_controller.mm

@@ -67,7 +67,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

@implementation ShippingOptionSelectionViewController

-@synthesize isLoading = _isLoading;

+@synthesize isPending = _isPending;

@synthesize errorMessage = _errorMessage;

- (instancetype)initWithPaymentRequest:(PaymentRequest*)paymentRequest {

@@ -110,7 +110,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

[model addSectionWithIdentifier:SectionIdentifierShippingOption];

- if (self.isLoading) {

+ if (self.isPending) {

StatusItem* statusItem = [[StatusItem alloc] initWithType:ItemTypeSpinner];

statusItem.text =

l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_CHECKING_LABEL);