Add Mojo constant for "ash" and replace hardcoded strings

mash/common/config.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/common/config.h"
 
+#if defined(USE_ASH)
+#include "ash/public/interfaces/constants.mojom.h"  // nogncheck
+#endif
 #include "base/command_line.h"
 
 namespace mash {
 namespace common {
 
 const char kWindowManagerSwitch[] = "window-manager";
 
 std::string GetWindowManagerServiceName() {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(kWindowManagerSwitch)) {
     std::string service_name =
         base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
             kWindowManagerSwitch);
     return service_name;
   }
-  // TODO(beng): move this constant to a mojom file in //ash.
-  return "ash";
+#if defined(USE_ASH)
+  return ash::mojom::kServiceName;
+#else
+  LOG(FATAL)
+      << "You must specify a window manager e.g. --window-manager=simple_wm";
+  return "";

[dcheng, 2017/02/22 18:01:07]

Nit: std::string() is more efficient than an implicit conversion from ""

+#endif
 }
 
 }  // namespace common
 }  // namespace mash