Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(102)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mash/common/BUILD.gn
Issue
2710673002
:
Add Mojo constant for "ash" and replace hardcoded strings (Closed)
Patch Set: Fix dep of simple_wm constants and (for completeness) make mojo interfaces a dep of simple_wm; add …
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
ash/public/interfaces/BUILD.gn
ash/public/interfaces/constants.mojom
mash/common/BUILD.gn
mash/common/config.cc
mash/simple_wm/BUILD.gn
mash/simple_wm/public/interfaces/BUILD.gn
mash/simple_wm/public/interfaces/OWNERS
mash/simple_wm/public/interfaces/constants.mojom
View unified diff
|
Download patch
« no previous file with comments
|
« ash/public/interfaces/constants.mojom
('k') |
mash/common/config.cc »
('j') |
mash/common/config.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
3 # found in the LICENSE file.
4
4
5
import("//build/config/ui.gni")
6
5 source_set("common") {
7 source_set("common") {
6 sources = [
8 sources = [
7 "config.cc",
9 "config.cc",
8 "config.h",
10 "config.h",
9 ]
11 ]
10
12
11 deps = [
13 deps = [
12 "//base",
14 "//base",
13 ]
15 ]
16
17
if (use_ash) {
18
deps += [ "//ash/public/interfaces" ]
19
} else {
20
deps += [ "//mash/simple_wm/public/interfaces" ]
21
}
14 }
22 }
OLD
NEW
« no previous file with comments
|
« ash/public/interfaces/constants.mojom
('k') |
mash/common/config.cc »
('j') |
mash/common/config.cc »
('J')
Issue 2710673002: Add Mojo constant for "ash" and replace hardcoded strings (Closed)
Created 3 years, 10 months ago by fwang
Modified 3 years, 10 months ago
Reviewers: Ben Goodger (Google), dcheng, tonikitoo, sky
Base URL:
Comments: 11
This is Rietveld
408576698
Chromium Code Reviews
Issue 2710673002:
Add Mojo constant for "ash" and replace hardcoded strings (Closed)
