Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: chrome/browser/net/url_request_mock_http_job.h

Issue 271066: Use FilePath in URLRequestMocks. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/url_request_mock_http_job.h
diff --git a/chrome/browser/net/url_request_mock_http_job.h b/chrome/browser/net/url_request_mock_http_job.h
index 92cc35975e683e0e5f106c178b42409770d26b00..b5ef7409db76c38e485df01790b5975ffef07ca1 100644
--- a/chrome/browser/net/url_request_mock_http_job.h
+++ b/chrome/browser/net/url_request_mock_http_job.h
@@ -11,6 +11,8 @@
#include "net/url_request/url_request_file_job.h"
+class FilePath;
+
class URLRequestMockHTTPJob : public URLRequestFileJob {
public:
URLRequestMockHTTPJob(URLRequest* request, const FilePath& file_path);
@@ -24,13 +26,13 @@ class URLRequestMockHTTPJob : public URLRequestFileJob {
static URLRequest::ProtocolFactory Factory;
// Adds the testing URLs to the URLRequestFilter.
- static void AddUrlHandler(const std::wstring& base_path);
+ static void AddUrlHandler(const FilePath& base_path);
// Given the path to a file relative to base_path_, construct a mock URL.
- static GURL GetMockUrl(const std::wstring& path);
+ static GURL GetMockUrl(const FilePath& path);
protected:
- static FilePath GetOnDiskPath(const std::wstring& base_path,
+ static FilePath GetOnDiskPath(const FilePath& base_path,
URLRequest* request,
const std::string& scheme);
@@ -39,7 +41,7 @@ class URLRequestMockHTTPJob : public URLRequestFileJob {
// This is the file path leading to the root of the directory to use as the
// root of the http server.
- static std::wstring base_path_;
+ static FilePath base_path_;
};
# endif // CHROME_BROWSER_NET_URL_REQUEST_MOCK_HTTP_JOB_H_
« no previous file with comments | « no previous file | chrome/browser/net/url_request_mock_http_job.cc » ('j') | chrome/browser/net/url_request_mock_http_job.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698