Issue 271066: Use FilePath in URLRequestMocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271066: Use FilePath in URLRequestMocks. (Closed)

Created:
11 years, 2 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Use FilePath in URLRequestMocks. BUG=24672 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29013

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -20 lines)			Patch
M	chrome/browser/net/url_request_mock_http_job.h	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/net/url_request_mock_http_job.cc	View	4 chunks	+9 lines, -8 lines	2 comments	Download
M	chrome/browser/net/url_request_mock_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_slow_http_job.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_request_slow_http_job.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/271066/diff/1/2 File chrome/browser/net/url_request_mock_http_job.cc (right): http://codereview.chromium.org/271066/diff/1/2#newcode16 Line 16: FILE_PATH_LITERAL(".mock-http-headers"); Nit: Maybe make this a char* ...

11 years, 2 months ago (2009-10-13 00:31:39 UTC) #2

Evan Martin

11 years, 2 months ago (2009-10-13 00:45:42 UTC) #3

http://codereview.chromium.org/271066/diff/1/2
File chrome/browser/net/url_request_mock_http_job.cc (right):

http://codereview.chromium.org/271066/diff/1/2#newcode16
Line 16: FILE_PATH_LITERAL(".mock-http-headers");
On 2009/10/13 00:31:39, tony wrote:
> Nit: Maybe make this a char* and use AppendASCII?

Unfortunately, AppendASCII is for appending path components (with slashes), not
just string appens.

Expand Messages | Collapse Messages