Specify patched_sdk location with --compile-sdk.

Specify patched_sdk location with --compile-sdk.

R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/e64167d42a5022d126cedc683e0b29775bff55c6

[ahe, 2017-02-21 10:04:15]

ahe@google.com changed reviewers:
+ karlklose@google.com, kustermann@google.com

[kustermann, 2017-02-21 11:30:17]

LGTM

So from this point on we can run fasta with the existing patched sdk and no
longer rely on dartk, right? This is awesome !

[ahe, 2017-02-21 11:33:02]

On 2017/02/21 11:30:17, kustermann wrote:
> LGTM
> 
> So from this point on we can run fasta with the existing patched sdk and no
> longer rely on dartk, right? This is awesome !

Well... Actually, you've been able to do so since
b62a37a36b2d01c3c27979a2cf5eada24afce035.

What this change does is remove the need to define the environment variable
DART_CONFIGURATION.

[kustermann, 2017-02-21 11:35:07]

On 2017/02/21 11:33:02, ahe wrote:
> On 2017/02/21 11:30:17, kustermann wrote:
> > LGTM
> > 
> > So from this point on we can run fasta with the existing patched sdk and no
> > longer rely on dartk, right? This is awesome !
> 
> Well... Actually, you've been able to do so since
> b62a37a36b2d01c3c27979a2cf5eada24afce035.
> 
> What this change does is remove the need to define the environment variable
> DART_CONFIGURATION.

Aha. I still used to generate the platform.dill file all the time.

[ahe, 2017-02-21 11:36:54]

On 2017/02/21 11:35:07, kustermann wrote:
> Aha. I still used to generate the platform.dill file all the time.

Thank you, BTW.

Also, this reminds me that I need to fix compile_platform to use fasta instead
of dartk.

[ahe, 2017-02-21 11:36:57]

Description was changed from

==========
Specify patched_sdk location with --compile-sdk.
==========

to

==========
Specify patched_sdk location with --compile-sdk.

R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e64167d42a5022d126cedc683e0b29775bff55c6
==========

[ahe, 2017-02-21 11:36:58]

Committed patchset #1 (id:1) manually as
e64167d42a5022d126cedc683e0b29775bff55c6 (presubmit successful).