Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/ui/views/hung_renderer_view_browsertest.cc

Issue 2710633003: Disable HungRendererDialogViewBrowserTest. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/hung_renderer_view_browsertest.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view_browsertest.cc b/chrome/browser/ui/views/hung_renderer_view_browsertest.cc
index aaeac411acbeac43c668be9f482c5d5bec7cf0a4..630877599d702353083ef62d440124565c1a5964 100644
--- a/chrome/browser/ui/views/hung_renderer_view_browsertest.cc
+++ b/chrome/browser/ui/views/hung_renderer_view_browsertest.cc
@@ -30,16 +30,12 @@ class HungRendererDialogViewBrowserTest : public DialogBrowserTest {
DISALLOW_COPY_AND_ASSIGN(HungRendererDialogViewBrowserTest);
};
-// TODO(tapted): On OSX the framework doesn't pick up the spawned dialog, and
-// the ASSERT_EQ in TestBrowserDialog::RunDialog() fails, so disabled for now.
-#if defined(OS_MACOSX)
-#define MAYBE_InvokeDialog_default DISABLED_InvokeDialog_default
-#else
-#define MAYBE_InvokeDialog_default InvokeDialog_default
-#endif
// Invokes the hung renderer (aka page unresponsive) dialog. See
// test_browser_dialog.h.
+// TODO(tapted): The framework sometimes doesn't pick up the spawned dialog and
+// the ASSERT_EQ in TestBrowserDialog::RunDialog() fails. This seems to only
+// happen on the bots. So the test is disabled for now.
IN_PROC_BROWSER_TEST_F(HungRendererDialogViewBrowserTest,
- MAYBE_InvokeDialog_default) {
+ DISABLED_InvokeDialog_default) {
RunDialog();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698