Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 271063002: Reintroduce proper checking for owner profile for the UI. (Closed)

Created:
6 years, 7 months ago by pastarmovj
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Reintroduce proper checking for owner profile for the UI. Fixes an issue where transient untrusted state is reported as permanent. BUG=362430 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pastarmovj
Hi Nikita, I think I found the issue with the device settings race. Can you ...
6 years, 7 months ago (2014-05-09 09:36:02 UTC) #1
pastarmovj
Hey Yuri, Nikita suggested you should take a look at this change too because you ...
6 years, 7 months ago (2014-05-12 08:42:12 UTC) #2
ygorshenin1
lgtm
6 years, 7 months ago (2014-05-12 09:05:15 UTC) #3
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 7 months ago (2014-05-12 09:14:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/271063002/1
6 years, 7 months ago (2014-05-12 09:14:47 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 11:04:31 UTC) #6
Message was sent while issue was closed.
Change committed as 269765

Powered by Google App Engine
This is Rietveld 408576698