[sync] Clean up path generation for the local sync database.

components/sync/driver/sync_service_base.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_BASE_H_
 #define COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_BASE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 22 matching lines @@
 // common functionality and member variables. Anything that can live inside the
 // sync component should eventually live here instead of a concrete
 // implementation. This is set up as a base class so things can be transferred
 // piece by piece as easily as possible.
 class SyncServiceBase : public SyncService, public SyncEngineHost {
  public:
   SyncServiceBase(std::unique_ptr<SyncClient> sync_client,
                   std::unique_ptr<SigninManagerWrapper> signin,
                   const version_info::Channel& channel,
                   const base::FilePath& base_directory,
+                  const base::FilePath& local_sync_directory,

[Nicolas Zea, 2017/02/21 23:58:40]

I wonder if this would be better plumbed in via the SyncClient, rather than as a
construction param. SyncClient is useful for abstracting away dependencies on
other areas of the code, which seems to fit the local sync logic.

[pastarmovj, 2017/02/22 14:23:14]

Another great idea! :) 

I think this clean up some more the code altogether.

                   const std::string& debug_identifier);
   ~SyncServiceBase() override;
 
   // SyncService partial implementation.
   void AddObserver(SyncServiceObserver* observer) override;
   void RemoveObserver(SyncServiceObserver* observer) override;
   bool HasObserver(const SyncServiceObserver* observer) const override;
 
  protected:
   // Notify all observers that a change has occurred.
@@ skipping 32 matching lines @@
 
   // The path to the base directory under which sync should store its
   // information.
   const base::FilePath base_directory_;
 
   // The full path to the sync data folder. The folder is not fully deleted when
   // sync is disabled, since it holds both Directory and ModelTypeStore data.
   // Directory files will be selectively targeted instead.
   const base::FilePath sync_data_folder_;
 
+  // The full path to the folder used for storing the local sync database.
+  // It is only used when sync is running against its local backend.
+  const base::FilePath local_sync_directory_;
+
   // An identifier representing this instance for debugging purposes.
   const std::string debug_identifier_;
 
   // The class that handles getting, setting, and persisting sync
   // preferences.
   SyncPrefs sync_prefs_;
 
   // A utility object containing logic and state relating to encryption. It is
   // never null.
   std::unique_ptr<SyncServiceCrypto> crypto_;
@@ skipping 17 matching lines @@
 
  private:
   bool GetLocalSyncConfig(base::FilePath* local_sync_backend_folder) const;
 
   DISALLOW_COPY_AND_ASSIGN(SyncServiceBase);
 };
 
 }  // namespace syncer
 
 #endif  // COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_BASE_H_