Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2710603009: Revert "Revert "[test.dart] Complain if there is non-utf8 formatted data in test output"" (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "[test.dart] Complain if there is non-utf8 formatted data in test output"" This reverts commit 7af8f320a770b36a4e54c0f32d091924b63a0d08. TBR=zra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2b81624bb2284e128cb6c5d5c94d3fc92097db19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -14 lines) Patch
M tests/standalone/io/console_unicode_test.dart View 1 chunk +8 lines, -9 lines 0 comments Download
A tests/standalone/io/non_utf8_output_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -1 line 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 15 chunks +50 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (2 generated)
bkonyi
3 years, 10 months ago (2017-02-24 01:08:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b81624bb2284e128cb6c5d5c94d3fc92097db19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698