Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2264)

Unified Diff: chrome/browser/resources/vr_shell/vr_shell_ui.js

Issue 2710593008: [VR Shell] Fix hidden elements being hit-testable. (Closed)
Patch Set: Ooops Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/ui_elements.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/vr_shell/vr_shell_ui.js
diff --git a/chrome/browser/resources/vr_shell/vr_shell_ui.js b/chrome/browser/resources/vr_shell/vr_shell_ui.js
index 2fd4a7a43d4b186dc18ed163e91a6d93d4779f01..bed2dcf932ee572a569d75cda5cd5ea3040f79b0 100644
--- a/chrome/browser/resources/vr_shell/vr_shell_ui.js
+++ b/chrome/browser/resources/vr_shell/vr_shell_ui.js
@@ -54,11 +54,12 @@ var vrShellUi = (function() {
// Place an invisible but hittable plane behind the content quad, to keep
// the reticle roughly planar with the content if near content.
let backPlane = new api.UiElement(0, 0, 0, 0);
- backPlane.setVisible(false);
+ backPlane.setVisible(true);
cjgrant 2017/02/24 14:25:23 Why not remove setVisible() and setHitTestable() c
mthiesse 2017/02/24 15:30:09 Done.
backPlane.setHitTestable(true);
backPlane.setSize(1000, 1000);
backPlane.setTranslation(0, 0, -0.01);
backPlane.setParentId(this.elementId);
+ backPlane.setFill(new api.Fill(api.FillType.None));
ui.addElement(backPlane);
this.updateState();
« no previous file with comments | « chrome/browser/android/vr_shell/ui_elements.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698