Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/android/vr_shell/ui_elements.cc

Issue 2710593008: [VR Shell] Fix hidden elements being hit-testable. (Closed)
Patch Set: Fix closure compiler error Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/vr_shell/vr_shell_ui.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/vr_shell/ui_elements.h" 5 #include "chrome/browser/android/vr_shell/ui_elements.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/browser/android/vr_shell/animation.h" 10 #include "chrome/browser/android/vr_shell/animation.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 ++it; 191 ++it;
192 } 192 }
193 } 193 }
194 } 194 }
195 195
196 bool ContentRectangle::IsVisible() const { 196 bool ContentRectangle::IsVisible() const {
197 return visible && computed_opacity > 0.0f; 197 return visible && computed_opacity > 0.0f;
198 } 198 }
199 199
200 bool ContentRectangle::IsHitTestable() const { 200 bool ContentRectangle::IsHitTestable() const {
201 return hit_testable; 201 return IsVisible() && hit_testable;
202 } 202 }
203 203
204 } // namespace vr_shell 204 } // namespace vr_shell
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/vr_shell/vr_shell_ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698