Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp

Issue 2710583005: Move SVGElement::buildPendingResourcesIfNeeded to SVGTreeScopeResources (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
index 4cb6f3c050ddf8282d65bece2d78da7fd4999d56..9617851877e31b78a83c69b68631c2ae233c8ad2 100644
--- a/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
@@ -8,6 +8,7 @@
#include "core/dom/TreeScope.h"
#include "core/layout/svg/LayoutSVGResourceContainer.h"
#include "core/layout/svg/SVGResourcesCache.h"
+#include "core/svg/SVGUseElement.h"
#include "wtf/text/AtomicString.h"
namespace blink {
@@ -152,6 +153,31 @@ SVGTreeScopeResources::removePendingResource(const AtomicString& id) {
return m_pendingResources.take(id);
}
+void SVGTreeScopeResources::notifyResourceAvailable(const AtomicString& id) {
+ if (id.isEmpty())
+ return;
+ // Get pending elements for this id.
+ SVGPendingElements* pendingElements = m_pendingResources.take(id);
+ if (!pendingElements)
+ return;
+ // Rebuild pending resources for each client of a pending resource that is
+ // being removed.
+ for (Element* clientElement : *pendingElements) {
+ DCHECK(clientElement->hasPendingResources());
+ if (!clientElement->hasPendingResources())
+ continue;
+ // TODO(fs): Ideally we'd always resolve pending resources async instead of
+ // inside insertedInto and svgAttributeChanged. For now we only do it for
+ // <use> since that would stamp out DOM.
+ if (isSVGUseElement(clientElement))
+ toSVGUseElement(clientElement)->invalidateShadowTree();
+ else
+ clientElement->buildPendingResource();
+
+ clearHasPendingResourcesIfPossible(clientElement);
+ }
+}
+
DEFINE_TRACE(SVGTreeScopeResources) {
visitor->trace(m_pendingResources);
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698